Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade yarn lock for webpack-license-checker #1183

Merged

Conversation

lneves12
Copy link

@lneves12 lneves12 commented Jul 25, 2019

What does this PR change?

Upgrade yarn lock for webpack-license-checker

Our javascript CI isn't auditing our devDependencies due to a yarn bug with workspaces: yarnpkg/yarn#7047

However github is still complaining about a lodash vulnerability in the webpack-license-checker.

Anyway checking for vulnerabilities in the devDependencies is not so critical since they are not included in the final bundles, but it's nice to have it clean 👍

GUI diff

No difference.

  • DONE

Documentation

  • No documentation neede

  • DONE

Test coverage

  • No tests:

  • DONE

Changelogs

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_lint_checkstyle"
  • Re-run test "java_pgsql_tests"
  • Re-run test "ruby_rubocop"
  • Re-run test "schema_migration_test_oracle"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@lneves12
Copy link
Author

@juliogonzalez can we merge this? :) Branch is still locked

@juliogonzalez juliogonzalez merged commit 1a4bc15 into uyuni-project:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants