-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[try_put_and_wait] Part 11: Add implementation of try_put_and_wait feature for continue nodes #1453
Merged
kboyarinov
merged 9 commits into
dev/kboyarinov/try_put_and_wait_production
from
dev/dnmokhov/try_put_and_wait_continue_node
Aug 23, 2024
Merged
[try_put_and_wait] Part 11: Add implementation of try_put_and_wait feature for continue nodes #1453
kboyarinov
merged 9 commits into
dev/kboyarinov/try_put_and_wait_production
from
dev/dnmokhov/try_put_and_wait_continue_node
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnmokhov
force-pushed
the
dev/dnmokhov/try_put_and_wait_continue_node
branch
from
July 20, 2024 16:32
45b93d4
to
324ac2d
Compare
kboyarinov
reviewed
Jul 23, 2024
Base automatically changed from
dev/kboyarinov/try_put_and_wait_function_node
to
dev/kboyarinov/try_put_and_wait_production
August 1, 2024 13:56
dnmokhov
force-pushed
the
dev/dnmokhov/try_put_and_wait_continue_node
branch
from
August 16, 2024 15:20
5989fed
to
a883693
Compare
dnmokhov
force-pushed
the
dev/dnmokhov/try_put_and_wait_continue_node
branch
from
August 16, 2024 15:53
a883693
to
1ac6688
Compare
…production' into dev/dnmokhov/try_put_and_wait_continue_node
…production' into dev/dnmokhov/try_put_and_wait_continue_node
kboyarinov
reviewed
Aug 21, 2024
dnmokhov
requested review from
kboyarinov,
aleksei-fedotov,
vossmjp,
pavelkumbrasev and
isaevil
August 21, 2024 23:36
kboyarinov
approved these changes
Aug 22, 2024
vossmjp
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too.
kboyarinov
merged commit Aug 23, 2024
99d7f3a
into
dev/kboyarinov/try_put_and_wait_production
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend continue_node interface with the new try_put_and_wait API for waiting on single messages.
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@
to send notificationsOther information