Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[try_put_and_wait] Part 11: Add implementation of try_put_and_wait feature for continue nodes #1453

Conversation

dnmokhov
Copy link
Contributor

Description

Extend continue_node interface with the new try_put_and_wait API for waiting on single messages.

Fixes # - issue number(s) if exists

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

@dnmokhov dnmokhov marked this pull request as ready for review July 20, 2024 16:28
@dnmokhov dnmokhov force-pushed the dev/dnmokhov/try_put_and_wait_continue_node branch from 45b93d4 to 324ac2d Compare July 20, 2024 16:32
@dnmokhov dnmokhov marked this pull request as draft July 20, 2024 16:53
test/tbb/test_continue_node.cpp Outdated Show resolved Hide resolved
include/oneapi/tbb/flow_graph.h Outdated Show resolved Hide resolved
include/oneapi/tbb/detail/_flow_graph_node_impl.h Outdated Show resolved Hide resolved
include/oneapi/tbb/flow_graph.h Show resolved Hide resolved
include/oneapi/tbb/detail/_flow_graph_body_impl.h Outdated Show resolved Hide resolved
@dnmokhov dnmokhov marked this pull request as ready for review July 24, 2024 23:41
Base automatically changed from dev/kboyarinov/try_put_and_wait_function_node to dev/kboyarinov/try_put_and_wait_production August 1, 2024 13:56
@dnmokhov dnmokhov force-pushed the dev/dnmokhov/try_put_and_wait_continue_node branch from 5989fed to a883693 Compare August 16, 2024 15:20
@dnmokhov dnmokhov force-pushed the dev/dnmokhov/try_put_and_wait_continue_node branch from a883693 to 1ac6688 Compare August 16, 2024 15:53
test/tbb/test_continue_node.cpp Outdated Show resolved Hide resolved
test/tbb/test_continue_node.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@vossmjp vossmjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@kboyarinov kboyarinov merged commit 99d7f3a into dev/kboyarinov/try_put_and_wait_production Aug 23, 2024
22 checks passed
@kboyarinov kboyarinov deleted the dev/dnmokhov/try_put_and_wait_continue_node branch August 23, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants