-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[try_put_and_wait] Part 6: Add implementation for limiter_node + reservation support for buffers #1425
Merged
kboyarinov
merged 53 commits into
dev/kboyarinov/try_put_and_wait_production
from
dev/kboyarinov/try_put_and_wait_limiter_node
Aug 16, 2024
Merged
[try_put_and_wait] Part 6: Add implementation for limiter_node + reservation support for buffers #1425
kboyarinov
merged 53 commits into
dev/kboyarinov/try_put_and_wait_production
from
dev/kboyarinov/try_put_and_wait_limiter_node
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kboyarinov
requested review from
aleksei-fedotov,
vossmjp,
pavelkumbrasev,
dnmokhov and
isaevil
June 26, 2024 15:40
…function_node' into dev/kboyarinov/try_put_and_wait_buffering_nodes
…buffering_nodes' into dev/kboyarinov/try_put_and_wait_limiter_node
…production' into dev/kboyarinov/try_put_and_wait_function_node
…function_node' into dev/kboyarinov/try_put_and_wait_buffering_nodes
…buffering_nodes' into dev/kboyarinov/try_put_and_wait_limiter_node
…production' into dev/kboyarinov/try_put_and_wait_buffering_nodes
…buffering_nodes' into dev/kboyarinov/try_put_and_wait_limiter_node
aleksei-fedotov
approved these changes
Aug 14, 2024
vossmjp
reviewed
Aug 15, 2024
Base automatically changed from
dev/kboyarinov/try_put_and_wait_buffering_nodes
to
dev/kboyarinov/try_put_and_wait_production
August 15, 2024 12:38
…production' into dev/kboyarinov/try_put_and_wait_limiter_node
Co-authored-by: Mike Voss <[email protected]>
…//github.com/oneapi-src/oneTBB into dev/kboyarinov/try_put_and_wait_limiter_node
13 tasks
vossmjp
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
kboyarinov
merged commit Aug 16, 2024
d67ee73
into
dev/kboyarinov/try_put_and_wait_production
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend limiter_node with try_put_and_wait API implementation and add reservation to buffer, queue, priority_queue and sequencer nodes to work correctly together with limiter_node
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@
to send notificationsOther information