Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[try_put_and_wait] Part 6: Add implementation for limiter_node + reservation support for buffers #1425

Conversation

kboyarinov
Copy link
Contributor

Description

Extend limiter_node with try_put_and_wait API implementation and add reservation to buffer, queue, priority_queue and sequencer nodes to work correctly together with limiter_node

Fixes # - issue number(s) if exists

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Base automatically changed from dev/kboyarinov/try_put_and_wait_buffering_nodes to dev/kboyarinov/try_put_and_wait_production August 15, 2024 12:38
Copy link
Contributor

@vossmjp vossmjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kboyarinov kboyarinov merged commit d67ee73 into dev/kboyarinov/try_put_and_wait_production Aug 16, 2024
21 of 22 checks passed
@kboyarinov kboyarinov deleted the dev/kboyarinov/try_put_and_wait_limiter_node branch August 16, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants