Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PKG_CONFIG_PATH in modulefiles #1279

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

omalyshe
Copy link
Contributor

@omalyshe omalyshe commented Dec 6, 2023

Description

This sets PKG_CONFIG_PATH in modulefiles. Without this change with modulefiles used it is not possible to find tbb using pkgconfig.

Fixes # - issue number(s) if exists

  • - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

@omalyshe omalyshe requested a review from isaevil December 6, 2023 13:41
Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omalyshe omalyshe merged commit 58653a3 into master Dec 6, 2023
20 checks passed
@omalyshe omalyshe deleted the dev/omalyshe/fix-modulefiles branch December 6, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants