-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DFT][MKLGPU] Use FWD/BWD_STRIDES #514
[DFT][MKLGPU] Use FWD/BWD_STRIDES #514
Conversation
MKL prints an warning to std::cerr at runtime, so I don't think this is the fix we're looking for. |
…essage * 2024.1's MKL prints a deprecation message when the deprecated INPUT/OUTPUT API is used. * This checks for 2024.1 and uses the new FWD/BWD stride API instead. * Also minor bugfix for CuFFT workspace size.
eba8191
to
9ae3a61
Compare
We should support the latest release as documented in the README so imo it is okay to require oneMKL 2024.1 and cleanup the code to use only fwd/bwd_stride when using the SYCL API from the Intel oneMKL library. |
I'll remove the support for 2024.0. In the meantime, it looks like I've somehow broken my implementation, so please hold off reviewing! |
I've updated the PR to remove support for earlier than 2024.1, and also to sort out an issue with exception handling. Test results are here: testres.txt Q: How come it was working earlier and then you said it was broken? |
@lhuot are you happy with this PR in its revised form? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the patch!
* INPUT/OUTPUT_STRIDES are deprecated in the oneMKL spec and Intel(R) oneMLK 2024.1 (the latest release) * Using them causes a warning message to be printed * This PR uses the new API: FWD/BWD_STRIDES
Description
sources/src/dft/backends/mklgpu/descriptor.cpp:30:29: warning: a declarative nested name specifier cannot name an alias template [-Walias-template-in-declaration-name]
Fixes #487
Checklist
All Submissions