Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add command line args for duckdb-server-rust #647

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

kwonoh
Copy link
Contributor

@kwonoh kwonoh commented Jan 2, 2025

This PR adds a few command line arguments for duckdb-server-rust.
I used clap for parsing arguments.

I set the database path as positional argument following the Python server (duckdb-server).

I am new to Rust so please review this carefully :)

> ./duckdb-server --help                                       
DuckDB Server for Mosaic.

Usage: duckdb-server [OPTIONS] [DATABASE]

Arguments:
  [DATABASE]  Path of database file (e.g., "database.db". ":memory:" for in-memory database) [default: :memory:]

Options:
  -p, --port <PORT>                                  HTTP Port [default: 3000]
      --connection-pool-size <CONNECTION_POOL_SIZE>  Max connection pool size [default: 10]
      --cache-size <CACHE_SIZE>                      Max number of cache entries [default: 1000]
  -h, --help                                         Print help
  -V, --version                                      Print version

@domoritz domoritz self-requested a review January 7, 2025 19:16
@domoritz domoritz merged commit 08bec1c into uwdata:main Jan 7, 2025
3 checks passed
@domoritz
Copy link
Member

domoritz commented Jan 7, 2025

thank you

@domoritz
Copy link
Member

domoritz commented Jan 7, 2025

Released in 0.2 alongside some other improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants