Send receiver a dm on CodeyCoin transfer to notify them #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probro27
requested changes
Jan 27, 2024
There was a problem hiding this comment.
@Fan-Yang-284 Couple of changes needed but solid work. Not sure why the message link is not showing up, since it does show up in the PR screenshots. I manually printed it out in the logs and it shows up as undefined, however message does exist (since message.guild?.name does show up correctly).
probro27
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
@Fan-Yang-284 LGTM! Works perfectly and should be good to go!
Thanks for working on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Upon transfers being initiated, send the receiving user a DM with a link to the transfer in order to notify them.
Also edits the transfer embed status message upon transfer completion to display user mentions instead of username
Motivation and Explanation
We previously added a timeout to transfers, so without the receiving user being aware of the transfer beforehand it is difficult to react and accept it within the timeout.
Related Issues
resolves #506
Steps to Reproduce
Coordinate with a second person to test transfers, or comment out the code that prevents sending transfers to oneself.
Demonstration of Changes
Further Information and Comments
Apologies for the delay in getting this fixed