-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
434 leetcode for codey #455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments.
problemId = problemIds[index]; | ||
} | ||
const problemData = await getLeetcodeProblemDataFromId(problemId); | ||
const content = getMessageForLeetcodeProblem(problemData).slice(0, 2000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we want to send multiple messages instead of just truncating the message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sending multiple messages might look weird if the truncation occurs in a weird spot, eg in the middle of a word.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is fair. I guess it might potentially mess up code blocks and equations as well, in which it might be more effort than what it is worth to detect them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary of Changes
Added commands for leetcode:
Motivation and Explanation
Leetcode Bot became broken - this functionality should replace it.
Related Issues
Resolves #434
Steps to Reproduce
Use the commands specified above.
Demonstration of Changes
Further Information and Comments
afterMessageReply
functionality.