Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed position #0 in coin leaderboard #420

Merged
merged 1 commit into from
Dec 25, 2022
Merged

Fixed position #0 in coin leaderboard #420

merged 1 commit into from
Dec 25, 2022

Conversation

Picowchew
Copy link
Collaborator

Summary of Changes

  • Fixed the bug where a user who is not on the coin leaderboard would have position #0
  • Stylized CodeyCoin as Codey coin
  • Removed the word "current" from the naming related to the coin leaderboard; if more leaderboards are to be added later, then adjectives can be added just for those

Motivation and Explanation

This fix would let a user see their correct position

Related Issues

Resolves #419

Steps to Reproduce

Try .coin lb when you are not on the coin leaderboard

Demonstration of Changes

Without ties:
image

With ties:
image

Further Information and Comments

@Picowchew Picowchew force-pushed the 419-fix-position-0-in-coin-leaderboard branch from 433f278 to 917d413 Compare December 24, 2022 16:53
mcpenguin
mcpenguin requested changes Dec 24, 2022
View reviewed changes
Copy link
Collaborator

@mcpenguin mcpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had a small change.

src/components/coin.ts Show resolved Hide resolved
mcpenguin
mcpenguin approved these changes Dec 25, 2022
View reviewed changes
Copy link
Collaborator

@mcpenguin mcpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon further research, it seems that LIMIT and OFFSET are usually on the same line. So this PR looks good to me now!

@Picowchew Picowchew merged commit 290a927 into main Dec 25, 2022
@Picowchew Picowchew deleted the 419-fix-position-0-in-coin-leaderboard branch December 25, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcpenguin mcpenguin mcpenguin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some users get #0 in coin leaderboard
2 participants
@Picowchew @mcpenguin