Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IRC_USER_ID to template #336

Merged
merged 1 commit into from
Aug 20, 2022
Merged

Conversation

KevinBacabac
Copy link
Contributor

Summary of Changes

Adds IRC_USER_ID to config/dev/vars.template.json

Motivation and Explanation

We underestimated issue 309 and needed 2 PRs to finish it

Demonstration of Changes

Look at the 2 line diff that would be 1 line if we had trailing commas in our linter.

Copy link
Collaborator

@Picowchew Picowchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

Copy link
Collaborator

@mcpenguin mcpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Picowchew Picowchew merged commit 38f0dbc into uwcsc:master Aug 20, 2022
@KevinBacabac KevinBacabac deleted the varstemplate branch August 20, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants