Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Office hours topic #290

Merged
merged 4 commits into from
Aug 14, 2022
Merged

Office hours topic #290

merged 4 commits into from
Aug 14, 2022

Conversation

KevinBacabac
Copy link
Contributor

Related Issues

#228

Summary of Changes and Steps to Reproduce

The office hours channel should display a topic corresponding with the time on Neil's API
image

Copy link
Collaborator

@mcpenguin mcpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@Picowchew Picowchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a very small comment, but other than that, looks good!

@@ -42,6 +42,9 @@ export const createOfficeStatusCron = (): CronJob =>
//discord channel names don't accept :emoji: so we have to use actual unicode
(response['status'] == 1 ? '✅' : response['status'] == 0 ? '❌' : '❓');
(messageChannel as TextChannel).setName(curName);
const time = Math.floor(response['time']);
const topic = `Last Updated At <t:${time}:F> for you (<t:${time}:R>)`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a super small nitpick, I think it would look nicer if the casing is "Last updated at" instead.

Copy link
Collaborator

@Picowchew Picowchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Picowchew Picowchew merged commit cf4b766 into uwcsc:master Aug 14, 2022
@KevinBacabac KevinBacabac deleted the officehours branch August 14, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants