-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Office hours topic #290
Office hours topic #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a very small comment, but other than that, looks good!
src/components/cron.ts
Outdated
@@ -42,6 +42,9 @@ export const createOfficeStatusCron = (): CronJob => | |||
//discord channel names don't accept :emoji: so we have to use actual unicode | |||
(response['status'] == 1 ? '✅' : response['status'] == 0 ? '❌' : '❓'); | |||
(messageChannel as TextChannel).setName(curName); | |||
const time = Math.floor(response['time']); | |||
const topic = `Last Updated At <t:${time}:F> for you (<t:${time}:R>)`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a super small nitpick, I think it would look nicer if the casing is "Last updated at" instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related Issues
#228
Summary of Changes and Steps to Reproduce
The office hours channel should display a topic corresponding with the time on Neil's API