Make /coin check default to the caller
#282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`/coin check` originally had a mandatory argument of a target user to check the balance of. Now the argument defaults to the user who called the command, making it more ergonomic to use.
mcpenguin
reviewed
Aug 13, 2022
|
Also please leave screenshots :)) |
- Also generalizes getUserIDFromMessage to just get the User straight up
- Updated previou references where relevant (leaderboard)
- Replaces "`user` has" with `You have` if the user is calling `/coin check`
on their own
|
Decided to remove the (added screenshots too) |
- `'b', 'bal', 'balance'` due to the removal of the balance subcommand
mcpenguin
approved these changes
Aug 15, 2022
Fixed the linter, but don't have write access 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
N/A
Summary of Changes
In comparison to
.coin, doing/coin checkand having to look for the target user was pretty time consuming when somebody just wanted to check their own balance. This PR makes theuserargument optional and defaults to checking the balance of the user who called the command if the arg is not provided.Steps to Reproduce
/coin checkand pass in no arguments.OR
.coin checkand pass in no arguments.Extra commentary
Not sure if
messageFromUser.member?.useris the "right" way to get the user, since for some reason accessingmembercan return null from aMessage?🤷