Exclude bots from leaderboard #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picowchew
reviewed
Aug 13, 2022
|
I might as well add that the change would be taking place in the messageCreate listener instead of the leaderboard, since bots shouldn't have a coin balance at all. Bots not appearing in the leaderboard would just be one effect of this. |
|
The issue has been updated just now for clearer specifications; sorry about that! |
|
No problem it's ready to test |
Picowchew
requested changes
Aug 14, 2022
src/listeners/messageCreate.ts
Outdated
| @@ -112,6 +113,11 @@ export class MessageCreateListener extends Listener { | |||
| return; | |||
| } | |||
There was a problem hiding this comment.
This case can be removed, since it is already covered below.
|
Also, do you mind adding 275813801792634880 as IRC_USER_ID for staging and updating README.md for the new config variable IRC_USER_ID? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#265
I don't have a database to test this ticket