Set activity and use codey coin emojis #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pls provide screenshots, thanks :)) |
|
Added |
|
when running .coin info: |
|
also the linter is angy |
|
I don't know why the linter is still angry |
Picowchew
requested changes
Aug 11, 2022
src/commandDetails/coin/info.ts
Outdated
Comment on lines
13
to
14
| const COIN = getCoinEmoji(); | ||
| const infoEmbed = new MessageEmbed() |
There was a problem hiding this comment.
My guess as to why "undefined" appeared in the coin info embed is that these constants are initialized before initEmojis() in ready.ts is completed (I don't currently have my dev environment with me to verify). Would the custom emoji show if you try placing these 2 constants into coinInfoExecuteCommand instead?
There was a problem hiding this comment.
Thanks it worked! The linter's nice
hydrobeam
added a commit
to hydrobeam/codeybot
that referenced
this pull request
Aug 13, 2022
`/coin check` originally had a mandatory argument of a target user to check the balance of. Now the argument defaults to the user who called the command, making it more ergonomic to use. Set activity and use codey coin emojis (uwcsc#276) * uwcsc#254 * Change default coin emoji to the Codey coin emoji * Add fallback if codeycoin emoji does not exist * Embed the codey coin image as a thumbnail * Fix bot.ts 43:32 linter issue * Fix undefined coin emoji in .coin info * Fix linter in adjust.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Resolves these issues.
#253
#254
Steps to Reproduce
The bot's status is Playing CSC | .help
Play blackjack and confirm codey coins appear properly.
