Fix aliases for subcommands #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcpenguin
requested review from
Picowchew and
marko-polo-cheno
and removed request for
Picowchew
marko-polo-cheno
approved these changes
Aug 7, 2022
| } | ||
| // If the subcommand is not an alias of another subcommand, use the default | ||
| if (!commandDetails) { | ||
| if (this.details.subcommandDetails !== {}) { |
There was a problem hiding this comment.
tho this does kinda look weird
There was a problem hiding this comment.
I'm not too sure how I could make this better
Coin is the only command that has been slashified and has subcommands and so is the only one relevant for this lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixed aliases for subcommands. This fix is only relevant for regular commands (slash commands don't need aliases.)
Screenshots