Codeycoin leaderboard #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Picowchew
requested changes
Aug 6, 2022
There was a problem hiding this comment.
I do not think that bots should be able to have Codey coins, and therefore bots should definitely not appear on the leaderboard. While this change might seem to be out of scope of this PR, I think it would be nice to include this change since the leaderboard is client-facing.
Also, it looks like there are some linter warnings.
marko-polo-cheno
requested changes
Aug 6, 2022
|
while u are here |
mcpenguin
force-pushed
the
195-codeycoin-leaderboard
branch
from
ce334c9
to
914d3a2
Compare
marko-polo-cheno
approved these changes
Aug 7, 2022
| @@ -61,6 +61,11 @@ export const coinBonusMap = new Map<BonusType, Bonus>([ | |||
| ] | |||
| ]); | |||
|
|
|||
| export interface UserCoinEntry { | |||
There was a problem hiding this comment.
I can't ctrl f on phone but can u just lmk where this is used XD
There was a problem hiding this comment.
In the leaderboard :))
Picowchew
approved these changes
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added a leaderboard for the top 10 CodeyCoin holders.
Steps to Reproduce
Run
.coin leaderboardor/coin leaderboard.Screenshots
The embed is the same regardless whether you use regular or slash commands.