Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of single quote character #215

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Fix use of single quote character #215

merged 1 commit into from
Jun 5, 2022

Conversation

victorzheng02
Copy link
Contributor

@victorzheng02 victorzheng02 commented Jun 5, 2022 •
edited
Loading

Related Issues

resolves #209.

Summary of Changes

  • Escaped all instances of single quote character, allowing it to be used in descriptions.
  • Note that this does NOT fix the use of double quotes. It seems sapphire does not support the quotation character as part of user args as it is already removed when first received.

Steps to Reproduce

  • .profile set aboutme SOME_DESCRIPTION_WITH_SINGLE_QUOTES
  • .profile about YOUR_USERNAME
  • Observe that the quotes appear properly now

image

@victorzheng02 victorzheng02 changed the title fixed Fix use of single quote character Jun 5, 2022
@victorzheng02 victorzheng02 merged commit 8f321ae into master Jun 5, 2022
alexz429 pushed a commit that referenced this pull request Jul 2, 2022
@victorzheng02 @alexz429
fixed (#215)
5d3154a
@Picowchew Picowchew deleted the user_profile_about_me_support_quotes branch August 25, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marko-polo-cheno marko-polo-cheno marko-polo-cheno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] User Profile About Me does not support double quotes or single quotes
2 participants
@victorzheng02 @marko-polo-cheno