Roll dice command #136
Merged
Roll dice command #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzcharleszhang
requested changes
Jan 29, 2022
src/commands/fun/rollDice.ts
Outdated
| if (sides <= 0) { | ||
| return message.reply(`I cannot compute ` + sides + ' sides!'); | ||
| } | ||
| else if (sides > 1000000) { |
There was a problem hiding this comment.
Can change else if to an if since the previous of statement exits the function
gzcharleszhang
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Resolves Issue #95
Summary of Changes
Adds command .rd n which rolls an n-sided dice and pings the user with the returned value.
Steps to Reproduce