Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't upgrade system-installed version of pip #2030

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Conversation

ivan-c
Copy link
Member

@ivan-c ivan-c commented Apr 16, 2018

@ivan-c ivan-c requested a review from pbugni April 16, 2018 20:44
@ivan-c ivan-c merged commit 0b1788a into develop Apr 16, 2018
@ivan-c ivan-c deleted the bug/no-pip-upgrade branch April 16, 2018 20:44
@pbugni
Copy link
Collaborator

pbugni commented Apr 17, 2018

I believe this was a temporary upstream problem with pip. I'd rather see us continue to use the upgraded pip unless you have reason to believe this is a bad choice, @ivan-c ?

@ivan-c
Copy link
Member Author

ivan-c commented Apr 17, 2018

@pbugni From this comment, it sounds like the pip installed from debian package (system version of pip) shouldn't be modified, or doesn't expect to be run as root.

I think it's against recommended best practice to run pip as root to install python modules system-wide , since python modules come from an untrusted source. This is happening isolated inside a docker image, but is still swimming upstream, so I relented since the default pip inside debian stretch docker images should be good enough (9.0.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants