Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review page - Thank You Page #211

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

lorena-rosati
Copy link
Collaborator

@lorena-rosati lorena-rosati commented Feb 26, 2024

Notion ticket link

Review page - Thank You Page

Implementation description

  • Built and styled review thank you page such that it displays the information correctly, has the correct functionality, and matches Figma design presented in the ticket

Steps to test

  1. Run the frontend and backend
  2. Click on an applicant to review (may need to make some changes to the users table in the database to have access to do this)
  3. Go through each page of the application review process until you click "Finish", the page that I have modified is after that (the thank you page)

What should reviewers focus on?

  • Ensure UI matches implementation
  • Ensure behaviour is correct when buttons are clicked

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@lorena-rosati lorena-rosati changed the title [DRAFT] Review page - Thank You Page Review page - Thank You Page Feb 27, 2024
@lorena-rosati lorena-rosati marked this pull request as ready for review February 27, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant