Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style login page #34

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Style login page #34

merged 3 commits into from
Oct 30, 2024

Conversation

kenzysoror
Copy link
Contributor

Notion ticket link

Login Page

Implementation description

  • Add Sistema (colour) logo and create SistemaLogoColour component
  • Add "Only sign in with a Sistema email." text to index.tsx
  • Style SignInButton component
  • Remove SignOutButton and session from index.tsx

Steps to test

  1. Visit http://localhost:3000/
  2. Confirm "Sign in with Google" button functionality
  3. Use Developer Tools to experiment with UI on different screen layouts

Desktop Browser UI:
Screenshot 2024-10-08 221117

(Dev Tool) Tablet UI:
Screenshot 2024-10-08 222420

(Dev Tool) iPhone SE UI:
Screenshot 2024-10-08 222501

What should reviewers focus on?

  • UI alignment with mock
    screenshot_2024-10-01_at_9 21 19___pm

  • UI transferability (different screen sizes, orientations, etc.)

  • General code style/best practices

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 1:57am

src/pages/index.tsx Outdated Show resolved Hide resolved
src/components/SistemaLogoColour.tsx Show resolved Hide resolved
@RahulTandon1
Copy link
Collaborator

Hey! I don't think I have much to add to the review aside from what Chinemerem wrote.
If you agree with all the changes he's suggested and you plan on making changes to the code, could you please ping me once you're done with the changes so I can take another look?

Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the suggested changes prior to merging. Also, after you successfully address a comment you should mark it as resolved.

src/components/SignInButton.tsx Outdated Show resolved Hide resolved
src/components/SignInButton.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@RahulTandon1 RahulTandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review.
Thank you for the amazing work!!

@kenzysoror kenzysoror merged commit 434dab9 into main Oct 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants