-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xarray and Sliderule IO Improvements #31
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@Jack-Hayes I'm going to merge this since it has useful functions for AGU prep. Note this takes largely takes care of what you started in #30 but still would love your help with tests, docs, and any features you think are still missing (like the polygon validation). |
Gotcha! I'm hoping to implement that test and an example notebook for the docs once I make the loading faster with dask if that sounds good to you |
Great to explore dask, but it should be optional. Hoping we can offer options to directly load overviews (instead of full-res raster) from COGs, or load coarser raster products. |
Yes, could certainly revisit choice to use dask by default here (but can override by passing coincident/src/coincident/io/xarray.py Line 65 in 7ce2087
I'm not sure if it's better or not to include the kitchen sink of dependencies in this project or to keep a lot of the I/O and visualization dependencies as optional... Including everything is the current approach but may get complicated (for example if we add PDAL for custom 3DEP workflows, which pins older arrow & hdf versions which i'd like to avoid b/c of search relying on recent geoparquet/arrow)... Lines 70 to 74 in 7ce2087
With odc-stac, reading from appropriate overviews should happen automatically by setting the More discussion of reading overviews including confirming they are used via logging is here gjoseph92/stackstac#196 |
docs/releases.rst
api.rst