FIX: Resolved characteristic wavelength overestimation via re-scaling #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mptino
force-pushed
the
readimage
branch
2 times, most recently
from
3109e15 to
9d387d2
Compare
* Observed that large characteristic wavelengths are computed if image size is small which leads to poor shapelet kernel size and thus poor analysis * To combat this, enforced minimum (and adjusted maximum) image dimensions after loading image from src to yield proper wavelength values * Other minor changes include example 1, where ref. region coordinates have changed with new scaling enforcement
mptino
force-pushed
the
readimage
branch
2 times, most recently
from
73e1b8e to
7779133
Compare
mptino
force-pushed
the
readimage
branch
2 times, most recently
from
b6d3b02 to
029a267
Compare
|
@nasserma Please squash and merge since these commits are heavily related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shapelets/self_assembly/misc/read_image