-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More simplification (with a bonus performance boost) #5
Conversation
4a51907
to
d5e97d5
Compare
This yields another 1.20 performance improvement from 2.0 seconds to 1.7 seconds
Note entirely sure what's going on but there's some weird things happening in this branch when I try to run all the firefox files. |
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
=======================================
Coverage ? 75.71%
=======================================
Files ? 4
Lines ? 387
Branches ? 58
=======================================
Hits ? 293
Misses ? 78
Partials ? 16
Flags with carried forward coverage won't be shown. Click here to find out more. |
Alright, I'm putting this up for review anyway. The reason is that I want to have these cleanups before I start working on more fixes. It doesn't have to be perfect and we can fix more along the way. |
div_ceil
function:Display
impl, by precalculating the separator and using the padding functionality offormat!
.theoretical_max_num_lines
by usingenumerate
and only deal with the widths instead of the the wholeCell
.width_dimensions
.Once I had the example, I benchmarked this against
main
and already got a >2.58x improvement!EDIT: Got another performance boost from 2.1x to 2.5x faster