Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to add coverage #4

Merged
merged 1 commit into from
Nov 20, 2022
Merged

try to add coverage #4

merged 1 commit into from
Nov 20, 2022

Conversation

sylvestre
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@bfea0a5). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage        ?   75.23%           
=======================================
  Files           ?        3           
  Lines           ?      315           
  Branches        ?       45           
=======================================
  Hits            ?      237           
  Misses          ?       64           
  Partials        ?       14           
Flag Coverage Δ
macos_latest 75.23% <0.00%> (?)
ubuntu_latest 75.23% <0.00%> (?)
windows_latest 75.23% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tertsdiepraam
Copy link
Member

I think we don't need all platforms for this library, because there's no platform-specific code. Though adding them doesn't hurt I suppose.

@sylvestre
Copy link
Contributor Author

it is still good to have CI on different platforms :)

@tertsdiepraam
Copy link
Member

Fair enough! This looks good to me. Is it working as intended?

@sylvestre
Copy link
Contributor Author

yeah, ship it :)

@tertsdiepraam tertsdiepraam merged commit 5404a5d into main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants