Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract printing flags to a function #56

Merged
merged 1 commit into from
Dec 7, 2023
Merged

extract printing flags to a function #56

merged 1 commit into from
Dec 7, 2023

Conversation

tertsdiepraam
Copy link
Member

No description provided.

@tertsdiepraam tertsdiepraam force-pushed the extract-printing-flags branch from 0d975e3 to 217f57b Compare December 7, 2023 14:52
cakebaker
cakebaker reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What's the reason to move the function to lib.rs and not keep it in help.rs?

@tertsdiepraam
Copy link
Member Author

I've moved it out of the proc macro, so that the proc macro generates code using this function. That makes it easier to debug and edit

@cakebaker cakebaker merged commit 7ef0a6f into uutils:main Dec 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tertsdiepraam @cakebaker