Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Initial trait #51

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

tertsdiepraam
Copy link
Member

The Initial trait was unnecessary complexity. Instead of requiring it, the library now does not make any assumptions about the initial state of the settings. Instead, parse and try_parse take a self parameter that represents the initial state. The easiest way to do this is still via Default (i.e. Settings::default().parse(...)), but that is not necessary. This allows us to delete a bunch of code! Leaving this as a draft because I just wrote this very quickly had should look this over one more time later.

@tertsdiepraam tertsdiepraam force-pushed the remove-initial branch 3 times, most recently from 3a17ee4 to b8912b2 Compare December 3, 2023 16:00
@sylvestre
Copy link
Contributor

needs to be rebased :)

@tertsdiepraam tertsdiepraam marked this pull request as ready for review December 5, 2023 15:07
@tertsdiepraam
Copy link
Member Author

Done!

@tertsdiepraam tertsdiepraam merged commit c7c3f91 into uutils:main Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants