Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Initial
trait was unnecessary complexity. Instead of requiring it, the library now does not make any assumptions about the initial state of the settings. Instead,parse
andtry_parse
take aself
parameter that represents the initial state. The easiest way to do this is still viaDefault
(i.e.Settings::default().parse(...)
), but that is not necessary. This allows us to delete a bunch of code! Leaving this as a draft because I just wrote this very quickly had should look this over one more time later.