Unify the option/positional/free attributes into arg
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tertsdiepraam
changed the title
option/positional/free attributes into argoption/positional/free attributes into arg
tertsdiepraam
force-pushed
the
unify-arg-attributes
branch
from
7762cda to
72fb31e
Compare
tertsdiepraam
force-pushed
the
unify-arg-attributes
branch
from
72fb31e to
e6a7f37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #38 (reply in thread)
There is now only attribute for variants on the
Argumentsenum:arg. The type of argument is determined based on the first value:-or containing=, it is treated as an optional argument.The rest of the arguments of the attribute are then parsed based on the type of argument. We should then also make the error messages better. For example, if an argument is used that can only be used on a certain type of argument, we should tell the user which argument type does accept it.