Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w: implement --short option #61

Merged
merged 7 commits into from
May 14, 2024
Merged

Conversation

ant0nkress
Copy link
Contributor

Description

We check for the parameter -s | --short. If it is set we exclude printing of login time, JCPU time and PCPU time.

Testing

Added a test to make sure only necessary values are printed.

@sylvestre sylvestre force-pushed the 24-w-implement-short branch from 1dbdffc to 657e365 Compare April 18, 2024 07:49
@cakebaker
Copy link
Contributor

Can you please run cargo fmt? And did you notice that the test fails?

@cakebaker
Copy link
Contributor

@ant0nkress ping?

@cakebaker cakebaker linked an issue May 14, 2024 that may be closed by this pull request
@cakebaker cakebaker force-pushed the 24-w-implement-short branch from 374f338 to 9a68d92 Compare May 14, 2024 13:09
@cakebaker cakebaker force-pushed the 24-w-implement-short branch from 3bec2d3 to 76cc4eb Compare May 14, 2024 13:55
and switch if/else cases
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 51.26%. Comparing base (9391cf1) to head (c898182).
Report is 46 commits behind head on main.

Files Patch % Lines
src/uu/w/src/w.rs 28.57% 4 Missing and 1 partial ⚠️
tests/by-util/test_w.rs 78.94% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #61       +/-   ##
==========================================
+ Coverage   0.10%   51.26%   +51.15%     
==========================================
  Files         18       18               
  Lines       1841     2331      +490     
  Branches     239      340      +101     
==========================================
+ Hits           2     1195     +1193     
+ Misses      1839     1072      -767     
- Partials       0       64       +64     
Flag Coverage Δ
macos_latest 50.63% <57.14%> (?)
ubuntu_latest 46.58% <65.38%> (?)
windows_latest 0.10% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cakebaker cakebaker merged commit cb0681a into uutils:main May 14, 2024
15 checks passed
@cakebaker
Copy link
Contributor

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

w: Implement --short
2 participants