Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

free: prevent subtract with overflow on macOS #47

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

cakebaker
Copy link
Contributor

This PR should fix the "attempt to subtract with overflow" errors that make some tests fail on macOS. See, for example, https://github.com/uutils/procps/actions/runs/8505959792/job/23295337750?pr=37

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.42%. Comparing base (c5e7417) to head (b7d89f6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   45.53%   45.42%   -0.12%     
==========================================
  Files          15       15              
  Lines        1803     1803              
  Branches      240      240              
==========================================
- Hits          821      819       -2     
- Misses        853      854       +1     
- Partials      129      130       +1     
Flag Coverage Δ
macos_latest 44.28% <100.00%> (ø)
ubuntu_latest 45.29% <ø> (-0.12%) ⬇️
windows_latest 0.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit 65f933b into uutils:main Apr 1, 2024
14 of 15 checks passed
@cakebaker cakebaker deleted the free_fix_subtract_with_overflow branch April 2, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants