Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slabtop: Add command #42

Merged
merged 27 commits into from
Apr 16, 2024
Merged

slabtop: Add command #42

merged 27 commits into from
Apr 16, 2024

Conversation

Krysztal112233
Copy link
Collaborator

@Krysztal112233 Krysztal112233 commented Mar 29, 2024

fixes #31

@cakebaker cakebaker linked an issue Mar 29, 2024 that may be closed by this pull request
@cakebaker
Copy link
Contributor

Just a hint: instead of using "link to x" you can use one of Github's keywords like "fixes x" to link a PR to an issue.

@Krysztal112233 Krysztal112233 marked this pull request as draft March 31, 2024 13:29
@Krysztal112233
Copy link
Collaborator Author

Need to introduce the ratatui crate to implement the TUI, so mark pr as draft for the time being

Cargo.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 22.66667% with 232 lines in your changes are missing coverage. Please review.

Project coverage is 45.99%. Comparing base (0a85e96) to head (dfb9fa0).
Report is 9 commits behind head on main.

❗ Current head dfb9fa0 differs from pull request most recent head c4eaca7. Consider uploading reports for the commit c4eaca7 to get more accurate results

Files Patch % Lines
src/uu/slabtop/src/parse.rs 15.27% 170 Missing and 2 partials ⚠️
src/uu/slabtop/src/slabtop.rs 11.11% 52 Missing and 4 partials ⚠️
tests/by-util/test_slabtop.rs 93.54% 0 Missing and 2 partials ⚠️
src/uu/w/src/w.rs 0.00% 1 Missing ⚠️
tests/by-util/test_w.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   48.37%   45.99%   -2.38%     
==========================================
  Files          15       18       +3     
  Lines        1933     2187     +254     
  Branches      277      305      +28     
==========================================
+ Hits          935     1006      +71     
- Misses        839     1017     +178     
- Partials      159      164       +5     
Flag Coverage Δ
macos_latest 45.11% <22.66%> (-2.59%) ⬇️
ubuntu_latest 45.27% <22.33%> (-3.61%) ⬇️
windows_latest 0.10% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre
Copy link
Contributor

@Krysztal112233 is that still a draft?

@Krysztal112233
Copy link
Collaborator Author

@Krysztal112233 is that still a draft?

I have a branch that implements simple output, but does not implement the TUI

Implementing a TUI was a lot more trouble than I thought it would be

@Krysztal112233 Krysztal112233 force-pushed the main branch 2 times, most recently from 39f1fe8 to decffd4 Compare April 12, 2024 09:08
@Krysztal112233 Krysztal112233 marked this pull request as ready for review April 12, 2024 09:08
@Krysztal112233

This comment was marked as resolved.

src/uu/slabtop/src/data/test_data.txt Outdated Show resolved Hide resolved
src/uu/slabtop/src/parse.rs Outdated Show resolved Hide resolved
src/uu/slabtop/src/parse.rs Show resolved Hide resolved
tests/by-util/test_slabtop.rs Show resolved Hide resolved
@sylvestre
Copy link
Contributor

sorry, there is now a small conflict, could you please fix it? should be easy

@Krysztal112233
Copy link
Collaborator Author

sorry, there is now a small conflict, could you please fix it? should be easy

the conflict has been fixed

@Krysztal112233
Copy link
Collaborator Author

@sylvestre this pr almost complete, can you have a look about it?

@sylvestre sylvestre merged commit 9391cf1 into uutils:main Apr 16, 2024
13 checks passed
@sylvestre
Copy link
Contributor

terrific!

Cargo.toml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command slabtop
4 participants