Fix output formatting for free #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GNU free is using 11 chars wide for number, not 12. This was also causing a misalignement of the numbers with the title.
|
please don't look at the source of the GNU implementation. it is GPL code and incompatible with this license. |
|
also, could you please add a test https://github.com/uutils/procps/blob/main/tests/by-util/test_free.rs to make sure we don't regress? |
|
I've added the tests, tell me if you think I should test more. |
|
Sorry, I forgot to run |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GNU free is using 11 chars wide for number, not 12. This was also causing a misalignment of the numbers with the title.
The source for the 11 chars wide: https://gitlab.com/procps-ng/procps/-/blob/master/src/free.c?ref_type=heads#L336