Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

free: add unit to zero in human mode #252

Merged

Conversation

cakebaker
Copy link
Contributor

When using --human, values that are zero are currently shown without a unit in our implementation whereas the original free displays such values as 0B. This PR adds the missing unit to such values.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.76%. Comparing base (3bd07df) to head (ffbb6da).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/uu/free/src/free.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   60.75%   60.76%           
=======================================
  Files          44       44           
  Lines        4495     4496    +1     
  Branches      687      688    +1     
=======================================
+ Hits         2731     2732    +1     
- Misses       1608     1609    +1     
+ Partials      156      155    -1     
Flag Coverage Δ
macos_latest 46.17% <0.00%> (-0.02%) ⬇️
ubuntu_latest 58.58% <0.00%> (+0.05%) ⬆️
windows_latest 0.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit 44a7a97 into uutils:main Oct 14, 2024
15 of 16 checks passed
@cakebaker cakebaker deleted the free_add_unit_for_zero_values_in_human_mode branch October 14, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants