Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwdx: use usize when parsing pid, not i32 #240

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

cakebaker
Copy link
Contributor

This PR uses usize instead of i32 when parsing a PID and removes an unnecessary cast.

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.40%. Comparing base (a8b52ad) to head (2e01edd).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
- Coverage   65.16%   61.40%   -3.76%     
==========================================
  Files          42       42              
  Lines        4415     4415              
  Branches      702      680      -22     
==========================================
- Hits         2877     2711     -166     
- Misses       1535     1546      +11     
- Partials        3      158     +155     
Flag Coverage Δ
macos_latest 46.01% <100.00%> (-2.38%) ⬇️
ubuntu_latest 58.50% <100.00%> (-8.06%) ⬇️
windows_latest 0.06% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit 5e70c02 into uutils:main Oct 6, 2024
15 of 16 checks passed
@cakebaker cakebaker deleted the pwdx_change_type_of_pid branch October 6, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants