Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI and dev maintenance updates #43

Merged
merged 18 commits into from
May 29, 2023
Merged

CI and dev maintenance updates #43

merged 18 commits into from
May 29, 2023

Conversation

rivy
Copy link
Member

@rivy rivy commented May 27, 2023

No description provided.

@rivy rivy force-pushed the rf.dev branch 2 times, most recently from 5eba839 to 2a94d53 Compare May 27, 2023 20:35
@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #43 (22bc23d) into main (93f0df0) will increase coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head 22bc23d differs from pull request most recent head 797714f. Consider uploading reports for the commit 797714f to get more accurate results

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   94.94%   94.95%           
=======================================
  Files           4        4           
  Lines         950      951    +1     
=======================================
+ Hits          902      903    +1     
  Misses         48       48           
Flag Coverage Δ
macos_latest 99.31% <ø> (ø)
ubuntu_latest 99.31% <ø> (ø)
windows_latest 94.47% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/platform/unix.rs 99.00% <ø> (ø)
tests/integration_test.rs 100.00% <ø> (ø)
src/platform/windows.rs 93.46% <33.33%> (ø)
src/platform/windows_safe.rs 95.31% <100.00%> (+0.01%) ⬆️

@rivy rivy marked this pull request as draft May 28, 2023 04:21
@rivy rivy force-pushed the rf.dev branch 14 times, most recently from 22bc23d to 95d27c0 Compare May 29, 2023 03:28
@rivy rivy marked this pull request as ready for review May 29, 2023 05:39
@rivy rivy marked this pull request as draft May 29, 2023 05:40
@rivy
Copy link
Member Author

rivy commented May 29, 2023

This is ready for review, but it's on top of #42 to avoid CI failures based on docs.

This refactoring updates CI, decreasing redundancies, adding increased testing (doc and spell testing), while decreasing CI runtime by approximately 50% (up to 75% for some runs).

New configuration for git logs and CodeCov is also included.

Other minor changes are included so that the new CI tests all pass.

I make it ready, and rebase it on 'main', when #42 is merged.

@rivy
Copy link
Member Author

rivy commented May 29, 2023

@sylvestre , @tertsdiepraam

Once this is merged, I'll post a draft PR that has the 100% code coverage refactor.
I'm interested in both of your opinions on it.
It adds a lot of testing flexibility, but at the cost of some boilerplate and a lot of secondary dependencies.

@sylvestre sylvestre marked this pull request as ready for review May 29, 2023 07:56
@sylvestre sylvestre merged commit c0c6f97 into uutils:main May 29, 2023
@sylvestre
Copy link
Contributor

@rivy maybe 2.1.0 for the next release ? :)

@rivy rivy deleted the rf.dev branch May 29, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants