Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove CARGO_FEATURES_OPTION #106

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Nov 8, 2024

While looking at the "code coverage" jobs I noticed that CARGO_FEATURES_OPTION is always empty when it's used. This PR adds the missing outputs CARGO_FEATURES_OPTION to ci.yml, though I'm not sure whether CARGO_FEATURES_OPTION is even needed. This PR removes CARGO_FEATURES_OPTION and adds --all-features to where CARGO_FEATURES_OPTION was used.

@cakebaker cakebaker force-pushed the ci_fix_cargo_features_option branch from 9fc79fb to b930211 Compare November 8, 2024 08:39
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (3101aa1) to head (90bed40).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   84.97%   84.97%           
=======================================
  Files          12       12           
  Lines        5829     5829           
  Branches      475      475           
=======================================
  Hits         4953     4953           
  Misses        861      861           
  Partials       15       15           
Flag Coverage Δ
macos_latest 84.93% <ø> (ø)
ubuntu_latest 85.17% <ø> (ø)
windows_latest 22.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cakebaker cakebaker force-pushed the ci_fix_cargo_features_option branch from b930211 to 90bed40 Compare November 8, 2024 08:48
@cakebaker cakebaker changed the title ci: add missing outputs CARGO_FEATURES_OPTION ci: remove CARGO_FEATURES_OPTION Nov 8, 2024
Copy link
Collaborator

@oSoMoN oSoMoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not making use of features anyway.

@oSoMoN oSoMoN merged commit dcd3dfd into uutils:main Nov 8, 2024
27 checks passed
@cakebaker cakebaker deleted the ci_fix_cargo_features_option branch November 8, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants