Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests in the upstream test suite marked as skipped are incorrectly considered failed #92

Closed
oSoMoN opened this issue Sep 27, 2024 · 0 comments · Fixed by #93
Closed

Tests in the upstream test suite marked as skipped are incorrectly considered failed #92

oSoMoN opened this issue Sep 27, 2024 · 0 comments · Fixed by #93
Assignees
@oSoMoN

Comments

@oSoMoN
Copy link
Collaborator

oSoMoN commented Sep 27, 2024

In the upstream test suite, a test that exits with code 77 is considered skipped.

However in the current implementation of tests/run-upstream-testsuite.sh, any code ≠ 0 is considered a failure.
@oSoMoN oSoMoN self-assigned this Sep 27, 2024
@oSoMoN oSoMoN mentioned this issue Sep 27, 2024
Merged
@oSoMoN oSoMoN linked a pull request Sep 28, 2024 that will close this issue
Upstream test suite: correctly handle tests that are skipped (fixes #92) #93
Merged
sylvestre added a commit that referenced this issue Oct 2, 2024
@sylvestre
Merge pull request #93 from oSoMoN/upstream-test-suite-skipped-tests-…
7480068 
…issue92

Upstream test suite: correctly handle tests that are skipped (fixes #92)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oSoMoN oSoMoN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upstream test suite: correctly handle tests that are skipped (fixes #92) oSoMoN/uutils-diffutils
1 participant
@oSoMoN