Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkfifo: better handle the mode + umask #6971

Merged
merged 1 commit into from
Dec 21, 2024
Merged

mkfifo: better handle the mode + umask #6971

merged 1 commit into from
Dec 21, 2024

Conversation

sylvestre
Copy link
Contributor

Should make tests/misc/mknod.sh pass

sylvestre
sylvestre commented Dec 18, 2024
View reviewed changes
src/uu/mkfifo/src/mkfifo.rs
@@ -6,6 +6,8 @@
use clap::{crate_version, Arg, ArgAction, Command};
use libc::mkfifo;
use std::ffi::CString;
use std::fs;
use std::os::unix::fs::PermissionsExt;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a unix only program :)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/existing-perm-race. tests/cp/existing-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/mknod is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/existing-perm-race. tests/cp/existing-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/misc/mknod is no longer failing!

@sylvestre
Copy link
Contributor Author

I think I regressed the these two tests

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/existing-perm-race. tests/cp/existing-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/mknod is no longer failing!

@sylvestre sylvestre force-pushed the mkfifo branch 4 times, most recently from 2260558 to 3bc1619 Compare December 19, 2024 21:19
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/misc/mknod is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@sylvestre
mkfifo: better handle the mode + umask
31ffc3a 
Should make tests/misc/mknod.sh pass
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/misc/mknod is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit a152687 into uutils:main Dec 21, 2024
62 checks passed
@cakebaker
Copy link
Contributor

Congrats! The gnu test tests/misc/mknod is no longer failing!

Cool :)

@sylvestre sylvestre deleted the mkfifo branch December 22, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

@jfinkels jfinkels Awaiting requested review from jfinkels

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker