Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tr: generate an error for real if the input is a directory #6907

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

sylvestre
Copy link
Contributor

should fix tests/misc/read-errors.sh for real

@sylvestre sylvestre marked this pull request as draft December 2, 2024 21:41
@sylvestre sylvestre force-pushed the tr2 branch 5 times, most recently from 0e6d900 to 74f6ffa Compare December 2, 2024 22:17
@sylvestre sylvestre marked this pull request as ready for review December 2, 2024 22:32
Copy link

github-actions bot commented Dec 2, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/read-errors is no longer failing!

Copy link

github-actions bot commented Dec 3, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/read-errors is no longer failing!

@sylvestre sylvestre force-pushed the tr2 branch 2 times, most recently from 2f577dd to 0547abf Compare December 3, 2024 09:51
Copy link

github-actions bot commented Dec 3, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/misc/read-errors is no longer failing!

@sylvestre sylvestre force-pushed the tr2 branch 3 times, most recently from 875ae0f to 14cf462 Compare December 3, 2024 12:22
Copy link

github-actions bot commented Dec 3, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/misc/read-errors is no longer failing!

src/uu/tr/src/tr.rs Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Dec 3, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/misc/read-errors is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre requested a review from cakebaker December 3, 2024 21:17
@cakebaker cakebaker merged commit d878f6c into uutils:main Dec 4, 2024
62 checks passed
@cakebaker
Copy link
Contributor

Congrats! The gnu test tests/misc/read-errors is no longer failing!

Great :)

@sylvestre sylvestre deleted the tr2 branch December 4, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants