Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ls: gnu color-norm test fix #6481

Merged
merged 6 commits into from
Jun 24, 2024
Merged

ls: gnu color-norm test fix #6481

merged 6 commits into from
Jun 24, 2024

Conversation

matrixhead
Copy link
Contributor

@matrixhead matrixhead commented Jun 18, 2024 •
edited
Loading

This pr tries to fix gnu test case color-norm for ls util
these behaviors that are changed

  • ls could now apply normal colour to non file names when --color is passed
    thanks @tavianator for helping me with issue.

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/ls/multihardlink. tests/ls/multihardlink is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/rm2. tests/rm/rm2 is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!

Sweet!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!

sylvestre
sylvestre reviewed Jun 19, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
sylvestre
sylvestre reviewed Jun 19, 2024
View reviewed changes
src/uu/ls/src/ls.rs Outdated Show resolved Hide resolved
sylvestre
sylvestre reviewed Jun 19, 2024
View reviewed changes
src/uu/ls/src/ls.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/sort/sort-debug-keys. tests/sort/sort-debug-keys is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
Congrats! The gnu test tests/timeout/timeout is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!

@sylvestre
Copy link
Contributor

excellent, please let me know when it is ready for review :)

@matrixhead matrixhead marked this pull request as ready for review June 24, 2024 06:46
@matrixhead matrixhead requested a review from sylvestre June 24, 2024 06:54
sylvestre
sylvestre reviewed Jun 24, 2024
View reviewed changes
util/build-gnu.sh Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!

@matrixhead matrixhead requested a review from sylvestre June 24, 2024 08:34
@sylvestre
Copy link
Contributor

I guess you saw:
error: the lock file /home/runner/work/coreutils/coreutils/Cargo.lock needs to be updated but --locked was passed to prevent this

@matrixhead
Copy link
Contributor Author

i need to add newly generated cargo.lock to fix this right? but other tests failing where failing when i do this

@sylvestre
Copy link
Contributor

See

error: package `clap_mangen v0.2.21` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0
Either upgrade to rustc 1.74 or newer, or use
cargo update -p [email protected] --precise ver
where `ver` is the latest version of `clap_mangen` supporting rustc 1.70.0

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/sort/sort-debug-keys. tests/sort/sort-debug-keys is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/dired is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!

@sylvestre
Copy link
Contributor

Three tests passing, this is amazing. well done!

@sylvestre sylvestre merged commit 9266514 into uutils:main Jun 24, 2024
68 of 70 checks passed
@matrixhead
Copy link
Contributor Author

thank you 😃 but 'stat-free-symlink' is still failing for me locally 😅

@BrewTestBot BrewTestBot mentioned this pull request Nov 16, 2024
Merged
@moonfruit moonfruit mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matrixhead @sylvestre