Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

du: make -l/--count-links work #5493

Merged
merged 2 commits into from
Nov 13, 2023
Merged

du: make -l/--count-links work #5493

merged 2 commits into from
Nov 13, 2023

Conversation

cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Nov 4, 2023 •
edited
Loading

So far, -l/--count-links were accepted as options and then ignored. This PR makes them work.

@cakebaker cakebaker marked this pull request as draft November 4, 2023 16:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/tail/inotify-dir-recreate is no longer failing!
GNU test failed: tests/du/deref. tests/du/deref is passing on 'main'. Maybe you have to rebase?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/tail/retry is no longer failing!

@cakebaker cakebaker marked this pull request as ready for review November 6, 2023 16:33
tertsdiepraam
tertsdiepraam approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one suggestion

src/uu/du/src/du.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

GNU testsuite comparison:

GNU test failed: tests/tail/truncate. tests/tail/truncate is passing on 'main'. Maybe you have to rebase?

@tertsdiepraam tertsdiepraam merged commit 0a07d47 into uutils:main Nov 13, 2023
41 of 51 checks passed
@cakebaker cakebaker deleted the du_inodes_with_count_links branch November 13, 2023 12:28
@chenrui333 chenrui333 mentioned this pull request Nov 14, 2023
Merged
@moonfruit moonfruit mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @tertsdiepraam