Add support in uucore for illumos and solaris

[bbarker]

The build was broken on these systems; confirmed working now on illumos. It should also work on solaris after conferring with a solaris developer.

[tertsdiepraam]

Cool! The only thing I don't really like is the macro for concatenating arrays. It's unfortunate that the lengths of the array are explicit for example. I'd like to propose this as an implementation for the ALL_SIGNALS static (simplified to just two signals):

#[cfg(target_os = "solaris")]
const SIGNALS_SIZE: usize = 1;

#[cfg(target_os = "illumos")]
const SIGNALS_SIZE: usize = 2;

#[cfg(or(target_os = "solaris", target_os = "illumos"))]
static ALL_SIGNALS: [&str; SIGNALS_SIZE] = [
    "HUP",
    #[cfg(target_os = "illumos")]
    "LWP",
];

[bbarker]

Thanks, that's a definite improvement! Pushed up the change 🙏

[sylvestre]

would it be possible to have a CI for these platforms ?

[bbarker]

I'd love to ... Think we'd have to fork the freebsd-vm project, so that might take me a while on my own.

…

On Fri, Nov 3, 2023, 3:38 AM Sylvestre Ledru ***@***.***> wrote: would it be possible to have a CI for these platforms ? — Reply to this email directly, view it on GitHub <#5489 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG7XDTSEHXIGT4CE7VJIKLYCSNONAVCNFSM6AAAAAA63UARBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJRHE4TEMJSHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[bbarker]

Is it OK to merge without the illumos CI support for now?

I will try to look into it. Have you had good success with your approach to FreeBSD CI?

[Toasterson]

would it be possible to have a CI for these platforms ?

I am a Maintainer with the OpenIndiana Project. The illumos reference distribution.
What platform do you need the CI on? We usually have either Jenkins or Buildomat as our CI runners but also have github action templates for VM's Seel Chezmoi for a contributed example https://github.com/twpayne/chezmoi/blob/v2.9.3/.github/workflows/main.yml#L173-L191

[tertsdiepraam]

Thanks for your input! We usually use GitHub Actions. If you could point us towards good templates or help us out with creating one, that would be great!

Also I don't think this PR is blocked by not having CI. Adding CI is a task that is big enough to be a separate PR as it will probably uncover more problems to fix.

[Toasterson]

@tertsdiepraam https://github.com/twpayne/chezmoi/blob/v2.9.3/.github/workflows/main.yml#L173-L191

[tertsdiepraam]

Thanks! I've made an issue for the CI here: #5492. @bbarker feel free to pick that up if you want!