nl: implement TryFrom<&str> for NumberingStyle #5156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakebaker
force-pushed
the
nl_implement_try_from_for_numbering_style
branch
from
95ea18a to
6bdeada
Compare
tertsdiepraam
approved these changes
Aug 12, 2023
|
I like the new version a lot better than the old one! |
cakebaker
force-pushed
the
nl_implement_try_from_for_numbering_style
branch
from
6bdeada to
d5ab7bb
Compare
cakebaker
changed the title
|
GNU testsuite comparison: |
tertsdiepraam
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
TryFrom<String>forNumberingStyleto replace theparse_stylefunction.