uucore: provide capacity for vectors #5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
cakebaker
reviewed
Jul 15, 2023
tests/by-util/test_factor.rs
Outdated
| @@ -233,7 +233,7 @@ fn test_random_big() { | |||
| // to generate an even split of this range, generate n-1 random elements | |||
| // in the range, add the desired total value to the end, sort this list, | |||
| // and then compute the sequential differences. | |||
| let mut f_bits = Vec::new(); | |||
| let mut f_bits = Vec::with_capacity(n_factors); | |||
There was a problem hiding this comment.
There's an additional f_bits.push directly after the for-loop (line 240):
Suggested change
| let mut f_bits = Vec::with_capacity(n_factors); | |
| let mut f_bits = Vec::with_capacity(n_factors + 1); |
cakebaker
approved these changes
Jul 15, 2023
|
@cakebaker thanks for the review :) |
|
I guess you didn't see perf improvement, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small improvements when creating vectors