Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add default_trait_access lint and fix its warnings #5081

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Jul 14, 2023

This PR adds the pedantic default_trait_access lint to the CICD and fixes its warnings.

@sylvestre
Copy link
Contributor

I guess you saw the similar warnings:

error: use of `default` to create a unit struct
  --> src/uucore/src/lib/features/tokenize/num_format/formatters/floatf.rs:13:13
   |
13 |         Self::default()
   |             ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
   = note: `-D clippy::default-constructed-unit-structs` implied by `-D warnings`

error: use of `default` to create a unit struct
  --> src/uucore/src/lib/features/tokenize/num_format/formatters/scif.rs:13:13
   |
13 |         Self::default()
   |             ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

@cakebaker
Copy link
Contributor Author

This is fixed in #5079

@sylvestre sylvestre force-pushed the ci_add_default_trait_access_lint branch from 20ca27e to 236789f Compare July 14, 2023 09:47
@cakebaker cakebaker force-pushed the ci_add_default_trait_access_lint branch 3 times, most recently from e969709 to 3dedce4 Compare July 14, 2023 10:52
@cakebaker cakebaker changed the title ci,tail: add default_trait_access lint and fix its warnings ci: add default_trait_access lint and fix its warnings Jul 14, 2023
@cakebaker cakebaker force-pushed the ci_add_default_trait_access_lint branch 2 times, most recently from fe42a6e to c525c23 Compare July 14, 2023 11:23
@cakebaker cakebaker force-pushed the ci_add_default_trait_access_lint branch from c525c23 to a0f527c Compare July 14, 2023 11:41
@sylvestre sylvestre merged commit 6f67c90 into uutils:main Jul 14, 2023
@cakebaker cakebaker deleted the ci_add_default_trait_access_lint branch July 15, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants