ci: Add a new workflow to check and format shell scripts in util dir

[starccy]

Hi,
I've added a new GitHub action workflow to resolve #4752. It utilizes shellcheck and shfmt tools to perform checks and formatting on our shell scripts during a push to the main branch or the creation of a PR.

As it stands, I would appreciate some input on the following aspects that may require further discussion or decision:

1. Unification of Shell Interpreters: It appears that some of our scripts utilize #!/bin/sh shebang, yet contain certain statements that do not adhere to the POSIX sh standard, as pointed out by shellcheck. I have attached an example of such an occurrence in the CI output from my forked repo here: ShellScript/Check. As a temporary measure, I've configured shellcheck to scrutinize all scripts against the bash rules. Would this be acceptable or should we strictly adhere to the $shebang rules?
2. Inclusion of Specific shellcheck Rules: Currently, I've left the shellcheck rules to their default settings, which still yield a number of warnings: ShellScript/Check. My plan is to address these in an additional commit, but before proceeding, it would be beneficial to determine which rules we should strictly enforce.
3. Auto Commit Post shfmt Execution: Once shfmt completes successfully, an automatic commit will be added to the main branch. I was wondering if this practice aligns with our workflow expectations.

[sylvestre]

please replace it by a failure, not an autofix :)

[starccy]

Got it, I'll remove the autofix code.

[sylvestre]

it didn't run. I guess it is because a new testsuite.
Let's see if it works if I merge it once you fixed the comment

[tertsdiepraam]

Yes, I think that's due to that security feature of github where it won't tun unmerged workflows.

[starccy]

I've removed any write operations. now the job will fail if the code does not meet the formatting specifications.

[sylvestre]

Let's try
Thanks

[starccy]

And as I've mentioned above, the job will be triggered if we modify the shell script under the util dir. But in the current situation, the shellcheck/shfmt will complain about some scripts. Should I add an additional commit to fix them?

[sylvestre]

yeah, please :)