cp: -i prompts in the right place and other improv #4925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
cakebaker
reviewed
Jun 1, 2023
tests/by-util/test_cp.rs
Outdated
Comment on lines
447
to
469
| fn test_cp_arg_interactive_update() { | ||
| // -u -i won't show the prompt to validate the override or not | ||
| // Therefore, the error code will be 0 | ||
| fn test_cp_arg_interactive_verbose() { | ||
| let (at, mut ucmd) = at_and_ucmd!(); | ||
| at.touch("a"); | ||
| at.touch("b"); | ||
| ucmd.args(&["-i", "-u", "a", "b"]) | ||
| ucmd.args(&["-vi", "a", "b"]) | ||
| .pipe_in("N\n") | ||
| .succeeds() | ||
| .no_stdout(); | ||
| .fails() | ||
| .stdout_is("skipped 'b'\n"); | ||
| } |
There was a problem hiding this comment.
What's the reason for replacing the -iu-test with a -vi-test?
There was a problem hiding this comment.
typo, let me fix that :)
sylvestre
force-pushed
the
cp-i
branch
2 times, most recently
from
240b247 to
a2e8004
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Jun 1, 2023
cakebaker
reviewed
Jun 1, 2023
Should fix tests/cp/cp-i.sh
|
GNU testsuite comparison: |
cakebaker
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.