more: implement arguments -n/--lines and --number #4914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
reviewed
May 29, 2023
src/uu/more/src/more.rs
Outdated
Comment on lines
561
to
562
| execute!(stdout, MoveUp(1)).unwrap(); | ||
| stdout.write_all("\n\r...back 1 page\n".as_bytes()).unwrap(); |
There was a problem hiding this comment.
maybe handle the errors ?
There was a problem hiding this comment.
I use the ? operator to propagate the Err result as a UResult.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2320
The match option assigns a value to the
linesvariable based on the provided options.It prioritizes the value obtained from the
--linesoption over the--numberoption.If a value of 0 is given for
lines, it will fallback to using the terminal size.