Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp: Accept --preserve=link #4910

Merged
merged 1 commit into from
May 29, 2023
Merged

cp: Accept --preserve=link #4910

merged 1 commit into from
May 29, 2023

Conversation

sylvestre
Copy link
Contributor

Used for example in:
tests/mv/hard-3.sh

Used for example in:
tests/mv/hard-3.sh
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@@ -713,7 +721,7 @@ impl Attributes {
"ownership" => self.ownership = preserve_yes_required,
"timestamps" => self.timestamps = preserve_yes_required,
"context" => self.context = preserve_yes_required,
"links" => self.links = preserve_yes_required,
"link" | "links" => self.links = preserve_yes_required,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably due to that "feature" of GNU where it accepts unambiguous prefixes of values. l, li, etc. will also work. But this fix is probably fine for now.

@sylvestre sylvestre merged commit d303af3 into uutils:main May 29, 2023
@sylvestre
Copy link
Contributor Author

thanks

@sylvestre sylvestre deleted the hard-3 branch May 29, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants