-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more: add arguments print over and clean print #4872
more: add arguments print over and clean print #4872
Conversation
The test is failing:
|
GNU testsuite comparison:
|
tests/by-util/test_more.rs
Outdated
#[test] | ||
fn test_valid_arg() { | ||
if std::io::stdout().is_terminal() { | ||
new_ucmd!().arg("-c").succeeds().code_is(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code_is(0)
is not necessary, it's already implied by succeeds()
.
While |
I have corrected the behavior of the two commands because they were not functioning properly previously. |
GNU testsuite comparison:
|
Thanks for your PR :) |
#2320
This pull request adds two arguments:
-c
,--print-over
and-p
,--clean-print
.I have included them in an
if ... else if
block because when both-c
and-p
are provided, it results in the--print-over
options being applied.